ENH: make ApplyToImageMetadata available in Python wrapping by dzenanz · Pull Request #6804 · InsightSoftwareConsortium/ITK

dzenanz · 2026-08-25T20:26:22Z

PR Checklist

No API changes were made (or the changes have been approved)
No major design changes were made (or the changes have been approved)
Added test (or behavior not changed)
Updated API documentation (or API not changed)

dzenanz · 2026-08-26T14:12:48Z

Actions update split out into #6806.

greptile-apps · 2026-08-26T15:37:05Z

Greptile Summary

This change exposes transform metadata application to Python and adds a Python test for that behavior. The new test always requests 3D wrapped image and transform types, but its CMake registration is not limited to builds that enable dimension 3. As a result, Python wrapping builds configured without 3D support can register a test that cannot run.

T-Rex validation blocked

The direct reduced-dimension configuration check could not complete because the cmake tool is missing. The attempted configuration with ITK_WRAP_PYTHON=ON and ITK_WRAP_IMAGE_DIMS=2 exited with status 127 before CMake could generate the test manifest or run the test.

Confidence Score: 4/5

The change is not safe for Python wrapping configurations that intentionally exclude 3D image types until the test registration is gated by the available wrapped dimensions.

One non-security build-compatibility issue remains: the test registration does not match the fixed 3D types used by the test. The source relationship is clear, although the reduced-dimension build could not be configured locally because CMake is unavailable.

Files Needing Attention: Modules/Core/Transform/wrapping/test/CMakeLists.txt needs a dimension-3 wrapping guard around itkApplyToImageMetadataTest; Modules/Core/Transform/wrapping/test/itkApplyToImageMetadataTest.py establishes the test's fixed 3D dependency.

T-Rex Logs

What T-Rex did

The 2D wrapping probe script was uploaded and identified as the minimal configuration probe.
The first blocked probe output log was uploaded, showing the attempted command, the working directory, the missing cmake failure, and exit status 127.
The repeated blocked probe output log was uploaded, providing corroborating evidence of the same missing cmake failure and exit status 127.

_{Ran code and verified through T-Rex}

_{Reviews (1): Last reviewed commit: "ENH: make ApplyToImageMetadata available..." | Re-trigger Greptile}

dzenanz · 2026-08-26T22:48:47Z

This is ready for review. CI is green.

dzenanz · 2026-08-27T17:46:08Z

The force-push introduces compile error in Python wrapping locally:

      C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(560,3):
      could be 'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(itk::SmartPointer<T>) const'
          C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(20576,39):
          'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(itk::SmartPointer<T>) const': could not deduce template argument for 'itk::SmartPointer<T>' from 'itkImageBase2 *'
      C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(554,3):
      or       'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(TImage *) const'
          C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(20576,39):
          Failed to specialize function template 'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(TImage *) const'
              C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(20576,39):
              With the following template arguments:
                  C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(20576,39):
                  'TImage=itkImageBase2'
              C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(553,8):
              'std::enable_if_t<false,void>' : Failed to specialize alias template
C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(25254,40): error C2672: 'itk::Transform<double,2,3>::ApplyToImageMetadata': no matching overloaded function found
      C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(560,3):
      could be 'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(itk::SmartPointer<T>) const'
          C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(25254,40):
          'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(itk::SmartPointer<T>) const': could not deduce template argument for 'itk::SmartPointer<T>' from 'itkImageBase2 *'
      C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(554,3):
      or       'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(TImage *) const'
          C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(25254,40):
          Failed to specialize function template 'enable_if<TImage::ImageDimension==2&&TImage::ImageDimension==3,void>::type itk::Transform<double,2,3>::ApplyToImageMetadata(TImage *) const'
              C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(25254,40):
              With the following template arguments:
                  C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(25254,40):
                  'TImage=itkImageBase2'
              C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(553,8):
              'std::enable_if_t<false,void>' : Failed to specialize alias template
C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40): error C2672: 'itk::Transform<TParametersValueType,3,2>::ApplyToImageMetadata': no matching overloaded function found
C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40): error C2672:         with
C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40): error C2672:         [
C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40): error C2672:             TParametersValueType=double
C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40): error C2672:         ]
      C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(560,3):
      could be 'enable_if<TImage::ImageDimension==3&&TImage::ImageDimension==2,void>::type itk::Transform<TParametersValueType,3,2>::ApplyToImageMetadata(itk::SmartPointer<T>) const'
          with
          [
              TParametersValueType=double
          ]
          C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40):
          'enable_if<TImage::ImageDimension==3&&TImage::ImageDimension==2,void>::type itk::Transform<TParametersValueType,3,2>::ApplyToImageMetadata(itk::SmartPointer<T>) const': could not deduce template argument for 'itk::SmartPointer<T>' from 'itkImageBase3 *'
          with
          [
              TParametersValueType=double
          ]
      C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(554,3):
      or       'enable_if<TImage::ImageDimension==3&&TImage::ImageDimension==2,void>::type itk::Transform<TParametersValueType,3,2>::ApplyToImageMetadata(TImage *) const'
          with
          [
              TParametersValueType=double
          ]
          C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40):
          Failed to specialize function template 'enable_if<TImage::ImageDimension==3&&TImage::ImageDimension==2,void>::type itk::Transform<TParametersValueType,3,2>::ApplyToImageMetadata(TImage *) const'
          with
          [
              TParametersValueType=double
          ]
              C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40):
              With the following template arguments:
                  C:\Misc\ITK-patches-dev-py26\Wrapping\Modules\ITKTransform\itkTransformBasePython.cpp(29932,40):
                  'TImage=itkImageBase3'
              C:\Misc\ITK-patches-dev\Modules\Core\Transform\include\itkTransform.h(553,8):
              'std::enable_if_t<false,void>' : Failed to specialize alias template

dzenanz · 2026-09-01T17:50:32Z

The latest force-push works locally (compiles and test passes).

dzenanz · 2026-09-01T17:52:25Z

The second force-push is a plain rebase.

blowekamp

Sorry I was not clearer in my initial explanation of recommended behavior of these functions. Please consider documentation that make this behavior compile-time vs run-time clear. Additionally, I believe the "else" branch will go into doxygen, please add clear documentation there.

hjmjohnson

After comment clarification is made, merge is approved.

dzenanz · 2026-09-03T16:02:24Z

I believe that the docstring preceding the #if will be in the documentation due to @ITKStartGrouping, and not comments inside #if or #else branches. I am about to update the docstring.

dzenanz · 2026-09-03T16:15:36Z

Comments updated. Confirmed via a local build that the docstring before the #if makes it into the documentation.

dzenanz force-pushed the pythonApplyToImageMetadata branch 2 times, most recently from 93007ab to 74ae5e0 Compare August 25, 2026 21:05

This comment was marked as resolved.

Sign in to view

blowekamp reviewed Aug 26, 2026

View reviewed changes

Comment thread Modules/Core/Transform/include/itkTransform.h

dzenanz force-pushed the pythonApplyToImageMetadata branch from 74ae5e0 to 32b44f6 Compare August 26, 2026 15:02

dzenanz marked this pull request as ready for review August 26, 2026 15:30

greptile-apps Bot reviewed Aug 26, 2026

View reviewed changes

Comment thread Modules/Core/Transform/wrapping/test/CMakeLists.txt Outdated

dzenanz force-pushed the pythonApplyToImageMetadata branch 2 times, most recently from cc5694f to 7ebba67 Compare August 26, 2026 18:01

dzenanz mentioned this pull request Aug 27, 2026

STYLE: Replace ULL with IT as index type in itkPyVectorContainerTest.py #6807

Merged

dzenanz force-pushed the pythonApplyToImageMetadata branch from 7ebba67 to be7dae2 Compare August 27, 2026 17:20

dzenanz force-pushed the pythonApplyToImageMetadata branch from be7dae2 to 7d734ec Compare September 1, 2026 17:49

dzenanz force-pushed the pythonApplyToImageMetadata branch from 7d734ec to e4c5a9d Compare September 1, 2026 17:52

dzenanz requested a review from blowekamp September 3, 2026 10:38

blowekamp approved these changes Sep 3, 2026

View reviewed changes

Comment thread Modules/Core/Transform/include/itkTransform.h Outdated

hjmjohnson approved these changes Sep 3, 2026

View reviewed changes

ENH: make ApplyToImageMetadata available in Python wrapping

a207eed

dzenanz force-pushed the pythonApplyToImageMetadata branch from e4c5a9d to a207eed Compare September 3, 2026 16:14

hjmjohnson approved these changes Sep 3, 2026

View reviewed changes

dzenanz merged commit 58e6345 into InsightSoftwareConsortium:main Sep 3, 2026
19 checks passed

dzenanz deleted the pythonApplyToImageMetadata branch September 3, 2026 20:44

Uh oh!

Uh oh!

Conversation

dzenanz commented Aug 25, 2026

PR Checklist

Uh oh!

This comment was marked as resolved.

Uh oh!

dzenanz commented Aug 26, 2026

Uh oh!

greptile-apps Bot commented Aug 26, 2026

Greptile Summary

T-Rex validation blocked

Confidence Score: 4/5

T-Rex Logs

Uh oh!

Uh oh!

dzenanz commented Aug 26, 2026

Uh oh!

dzenanz commented Aug 27, 2026

Uh oh!

dzenanz commented Sep 1, 2026

Uh oh!

dzenanz commented Sep 1, 2026

Uh oh!

blowekamp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hjmjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

dzenanz commented Sep 3, 2026

Uh oh!

dzenanz commented Sep 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants